adamsaghy commented on PR #6399: URL: https://github.com/apache/fineract/pull/6399#issuecomment-5763769835
@oleksii-novikov-onix Please review below findings / concerns: - WorkingCapitalLoanChargeWritePlatformServiceImpl.java:487 — A waiver backdated to the charge's past due date stamps closedOnDate/maturedOnDate with that date, plus the closure amortization and accrual postings. Fee due 15 Jan, principal repaid 1 Mar, waived 1 Apr → loan is recorded as closed on 15 Jan, before its own last repayment. adjustmentForLoanCharge in the same class uses the business date for these calls; the e2e scenarios never hit it (UC7's due date equals the business date). - WorkingCapitalLoanChargeWritePlatformServiceImpl.java:483 — reprocessTransactions(loan) is called without the paired delinquencyRangeScheduleService.reprocessDelinquencySchedule(loan). The replay shifts principal across dates, which applyRemainingBalanceCap/classifyDelinquency depend on. processRepaymentLikeTransaction, undoTransaction, and undoChargeWaiver (added in this same PR) all pair the two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
