Aman-Mittal opened a new issue, #579:
URL: https://github.com/apache/fineract-backoffice-ui/issues/579
`/organization/currencies` is a two-list transfer control listing every
currency the platform knows. Two separate problems.
> **Screenshot:** _Currency Configuration at 1440px, dark theme — the
unfiltered Available list and the two transfer buttons._ (attached below)
## 1. The doubled arrow is a real string bug
Both button labels already carry an arrow in the translation, and the
template adds a second one:
```json
"ADD": "Add →",
"REMOVE": "← Remove",
```
`src/assets/i18n/en.json:137-138`
```html
{{ 'CURRENCIES.ADD' | translate }} →
← {{ 'CURRENCIES.REMOVE' | translate }}
```
`src/app/features/organization/currencies/currencies.component.ts:86,89`
So the rendered labels are literally `"Add → →"` and `"← ← Remove"`
(confirmed by reading `textContent`; the buttons have no `ion-icon` children,
so this is text, not an icon plus a glyph).
**Suggested fix** — take the arrow out of the translation strings and keep
it in the template, so translators get a clean `"Add"` / `"Remove"` and the
direction stays a presentational concern. Doing it the other way round leaves
an arrow inside a string that RTL locales would need to mirror.
## 2. The screen does not scale to the number of options it shows
Measured on the deployed build:
| | |
|---|---|
| Checkboxes in **Available Currencies** | **164** |
| Search / filter on the list | **none** |
| Paging | none |
| Page `scrollHeight` | **8107 px** |
| Position of **Save** | bottom of the page |
To enable one currency the user has to scroll an alphabetical list of 164
entries to find it, tick it, scroll back up to `Add →`, then scroll roughly
8000 px to reach `Save`. On a phone this is considerably worse.
The list is also the only place in the app using native checkboxes; the rest
of the product uses Ionic controls.
**Suggested fix**, roughly in value order:
- add a filter input above **Available Currencies** (typing "fra" should
leave Swiss Franc and CFA Franc) — this alone fixes most of the pain;
- keep the `Add` / `Remove` controls and `Save` in view while the lists
scroll, rather than letting `Save` sit past 8000 px of content;
- give each list its own scroll area so the page stops being 8107 px tall;
- swap the native checkboxes for the shared control used elsewhere.
## Reproduction
1. Sign in, go to **Organization → Currencies**.
2. Read the two transfer button labels — both show two arrows.
3. Try to enable a currency starting with "S" without using the browser's
own find-in-page.
## Tested against
Deployed build of `main`, Chrome, 1440x900. Line references are against
`27d5a441`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
