oleksii-novikov-onix commented on PR #6449: URL: https://github.com/apache/fineract/pull/6449#issuecomment-5765836199
> @oleksii-novikov-onix Please review the below finding / concern: > > * 0081_wc_loan_missing_command_permissions.xml:26 — UNDO_WORKINGCAPITALLOANTRANSACTION_CHECKER is not seeded, unlike the charge permission which does get its _CHECKER row. UNDO_WORKINGCAPITALLOANTRANSACTION is maker-checkerable (grouping isn't special, code isn't READ_*), so once a tenant enables maker-checker for it, validateHasCheckerPermissionTo requires UNDO_WORKINGCAPITALLOANTRANSACTION_CHECKER, which no role can be granted — leaving approval to CHECKER_SUPER_USER only, the same restriction the PR is removing. > > **Lets fix this as well please** > > * One prose nit, not reported as a finding: working-capital-recovery-payment.adoc:278 now reads "The reversal adds no permission of its own ... and is guarded by UNDO_WORKINGCAPITALLOANTRANSACTION", which reads as a contradiction unless you know the permission is the shared transaction-undo one. 1. Fixed - added changeset wcl-0081-4 seeding UNDO_WORKINGCAPITALLOANTRANSACTION_CHECKER (grouping transaction_loan, entity WORKINGCAPITALLOANTRANSACTION, action UNDO_CHECKER, can_maker_checker false), same shape as wcl-0044-6. 2. Fixed - reworded so the shared transaction-undo permission comes first and the negation last. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
