wellkilo opened a new pull request, #604: URL: https://github.com/apache/fineract-backoffice-ui/pull/604
## What and why Related to #569. This delivers the colour/tone slice without claiming the remaining `class` and tooltip cases. `app-icon` had no way to express status colour, so four already-identified screens could not leave the direct Ionic import. This adds a `success | warning | danger | neutral` tone input while keeping the vendor colour mapping private to the primitive. The three data-driven status icons now use application intent instead of vendor colour names, and `group-levels-list` drops its `local/no-vendor-ui-import` suppression. The primitive tests cover the unset default and require the four semantic tones to remain visually distinct without pinning Ionic's palette. The group-levels test also checks the migrated call site resolves to `tone="success"`. ## Verification - `npm run lint:prune` - `npm run format:check` - `npm run i18n:check` - `npm run check:icons` - `npm run check:a11y-names` - `npm run api:surface` - `npm run test:unit` — 248 files, 1,527 tests passed - `npm run build` — local environment limitation: exits with `SIGABRT` during native-federation bundling. The same failure reproduces on unmodified `main` with a clean `npm ci`, and emits no source diagnostic. ## Screenshots Not included. This changes the semantic colour source for status icons, but does not add a new screen or workflow. A mocked Playwright run was not available in this environment. ## AI assistance - Tool / model: OpenAI Codex desktop coding agent - Harness / workflow: local repository inspection, patch generation, and local validation under the repository's documented checks ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. (No new user-facing strings.) - [x] I added or updated tests appropriate to this change. - [ ] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. — Not run; this is a primitive and call-site contract change with unit coverage. - [x] Commits are signed — GitHub reports the commit as verified. - [x] I followed the AI-assisted contributions guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
