somasorosdpc commented on PR #6467: URL: https://github.com/apache/fineract/pull/6467#issuecomment-5830079941
@galovics * API compatibility should be decided by maintainers, as contacting to @adamsaghy we think it is fine. * We don't want to modify by update script the existing incorrect values, because in some cases, if custom transactions are implemented we should avoid data loss. * as you mentioned API Swagger descriptors and implementation could be tested by reflection only, i would avoid that solution. * keep serialization fix in a followup because it is way out of this ticket's scope * I removed unreachable null check part * we can't test with feign client the fails for enum types. I would skip it for now. * as an agreement, we can keep 2 individual commit in case different authors. This is the case now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
