wellkilo opened a new pull request, #606: URL: https://github.com/apache/fineract-backoffice-ui/pull/606
## What and why Fixes the mobile record-detail layout described in #574. At phone widths the shared header action row was clipped by `ion-card`'s `overflow-x: hidden`, leaving controls such as **Back**, **New Account**, **Withdraw**, and **Actions** unreachable. The two-column overview grid also caused labels and values to collide or truncate. The narrow-layout rules now live in the shared stylesheet, so client, loan, savings, deposit, and loan-product record views stack their actions and detail cards consistently instead of carrying duplicated desktop-only rules. Closes #574 ## Verification - `npm run lint` — passed - `npm run typecheck:e2e` — passed - `npm run check:responsive` — passed - `npm run format:check` — passed - `npm run build` — passed; the pre-existing `header.component.ts` stylesheet budget warning remains - `npm test -- --watch=false` — 248 test files, 1527 tests passed - `npx playwright test e2e/mobile-shell.spec.ts --project=mobile` — 17 tests passed - The new 390px cases cover client and savings record views, assert every visible action stays inside the viewport, the action row does not hide overflow, the overview grid is one column, and label/value rectangles do not collide - Commit `c52a63f` is signed and GitHub reports it as **Verified** The mobile coverage uses mocked API responses. No backend data or API contract changed, so a real-Fineract run was not needed for this layout-only fix. ## Screenshots The before screenshots and measurements are in [#574](https://github.com/apache/fineract-backoffice-ui/issues/574). The regression test now records the reachability and collision contract programmatically rather than adding binary artifacts to the repository. ## AI assistance (optional) - Tool / model: OpenAI Codex - Harness / workflow: ECC `source-command-feature-dev`, repository guidance in `AGENTS.md`, local unit/lint/build/Playwright verification ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. No component or service code was added. - [x] User-facing strings use translation keys. No user-facing strings were added. - [x] I added or updated tests appropriate to this change. - [x] UI workflow changes include suitable e2e coverage. Mocked coverage is sufficient because this is a responsive layout change with no backend behaviour. - [x] Commits are signed — `c52a63f` is Verified on GitHub. - [x] I followed the AI-assisted contributions guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
