Aman-Mittal opened a new pull request, #610:
URL: https://github.com/apache/fineract-backoffice-ui/pull/610
Builds on #608. That PR is the automated spec sync; it opened with `npm run
build` failing on two call sites, which is the outcome its own description says
is the point of opening it. This branch carries the same sync commit and adds
the fixes, so #608 can be closed in favour of this one.
## The two build errors
**`GET /savingsaccounts/{id}/onholdtransactions`** now returns a paged
envelope instead of a bare array:
```ts
interface GetSavingsAccountsSavingsAccountIdOnHoldTransactionsResponse {
pageItems?: Array<DepositAccountOnHoldTransactionData>;
totalFilteredRecords?: number;
}
```
The list component was typed `next: (data: string)` and hand-parsed a JSON
string. It now reads `data?.pageItems ?? []`. The `JSON.parse` branch is gone
rather than kept as a fallback — the generated client deserialises JSON itself,
so the string case was already unreachable.
**`GetRecurringDepositAccountsAccountIdResponse.recurringDepositAmount`**
was removed upstream. The replacement is `mandatoryRecommendedDepositAmount`,
which is the name the form already binds to on both the template and submit
sides, so the mapping becomes a straight rename:
```diff
- mandatoryRecommendedDepositAmount: data.recurringDepositAmount,
+ mandatoryRecommendedDepositAmount: data.mandatoryRecommendedDepositAmount,
```
Upstream also dropped `recurringDepositFrequency` /
`recurringDepositFrequencyType` and added `depositAmount`; nothing in the app
referenced those.
## Angular 22.1.0 → 22.2.0
Bumped across `core`, `common`, `compiler`, `animations`, `forms`,
`platform-browser`, `router`, `cdk`, `build`, `cli`, `compiler-cli`,
`build-angular` and `native-federation` (22.2.1, which peers `@angular/build`
`~22.2.0`).
**`package-lock.json` is regenerated.** Incremental installs could not
resolve: the pinned `native-federation` 22.1.1 peers `@angular/build`
`~22.1.0`, and the stale nested
`@angular-devkit/build-angular/node_modules/@angular/build` entry kept the
resolver from reconciling it against 22.2.0. Targeted `npm install` of the
Angular cluster hits the same `ERESOLVE`, so the lock had to be rebuilt. The
entry count drops 1492 → 1331, almost all of it nested duplicates collapsing
once `@angular/build` aligns at the top level.
`@ionic/angular` (8.8.19), `@ionic/core`, `@stencil/core`, `ionicons` and
`@ngx-translate/*` (17.0.0) are **unchanged** — their declared ranges were not
touched and the regenerated lock resolved them to the same versions.
## TypeScript stays at `~6.0.3`
Not an oversight. Angular 22.2's `compiler-cli` and `build` both declare:
```
"typescript": ">=6.0 <6.1"
```
so 7.0.2 is not installable against this Angular. 6.0.3 is the highest
release inside that range and is already what `~6.0.3` resolves to, so
TypeScript is at its ceiling until Angular widens the peer range.
`generate-api` moves its `ngVersion` property from 22.0.7 to 22.2.0 to match
the bump. Generated output is byte-identical either way — confirmed by
regenerating with both values.
## Verification
| Check | Result |
|---|---|
| `npm run build` | passes |
| `npm test` | 1536 passing, 249 files |
| `npm run lint` | clean, no new suppressions |
| `npm run verify-api-client` | no drift — client regenerates byte-identical
from the committed spec |
| `prettier --check` | clean |
| `typecheck:e2e`, `test:scripts`, `test:eslint-rules` | pass |
| `i18n:check`, `check:icons`, `check:a11y-names`, `check:ui-primitives`,
`check:internal-endpoints`, `check:route-permissions`, `check:nav-ids`,
`check:branding-path`, `check:responsive`, `check:version`, `api:surface`,
`check:licenses` | pass |
The pre-existing `header.component.ts` style-budget warning (4.00 kB budget,
5.12 kB actual) is unchanged by this branch.
Test coverage for the changed behaviour: the on-hold transactions spec moves
to the envelope shape and gains a case asserting an envelope with no
`pageItems` yields an empty list rather than throwing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
