shivaansh0610-LUFFY commented on issue #613: URL: https://github.com/apache/fineract-backoffice-ui/issues/613#issuecomment-5845932583
Hyy @Aman-Mittal , I've verified this against the git history and the analysis holds up exactly as described: 6f40cfc5 (in #601) correctly remapped --ion-color-primary to --primary-strong (#2471a3, 5.30:1). f8fcb45b, later in the same branch/PR, reverted just that mapping back to #3498db (3.15:1) and dropped the --ion-color-tertiary block along with it. main today still has the reverted, failing values in src/styles/_ionic-theme.scss. --primary-strong is still defined in _common.scss and already in use elsewhere (sidebar, header), so the fix is a straight re-application of 6f40cfc5's two-line change — no new token needed. I'd like to take this on: reapply the --ion-color-primary/--ion-color-primary-rgb mapping and restore the --ion-color-tertiary block, then add a regression test (contrast-ratio assertion on the shipped primary against white) so this can't silently revert again the way it did inside #601. Could I get assigned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
