shivaansh0610-LUFFY commented on issue #583: URL: https://github.com/apache/fineract-backoffice-ui/issues/583#issuecomment-5846124552
Hi @Aman-Mittal, I'd like to work on this issue! I went through guidance-tour.component.ts and confirmed the write-up against the code at 27d5a441: the card is pinned via position: fixed; bottom: 24px; right: 24px (lines 140-142) regardless of where the target is, there's no scrim — body.guidance-active only adds padding-bottom (lines 179-186) — and the highlight is just a 3px outline + 18% tinted box-shadow (lines 234-245), which has to compete with a fully-lit screen. scrollTargetIntoView centers the target (or scrolls it to the top on mobile) but has no awareness of where the card itself sits, so on a short page like Clients the two end up in opposite corners. My plan: Anchor the card near its target on wide screens — after findTarget resolves an element, compute its bounding rect and position the card beside or beneath the highlight instead of always bottom-right, flipping side/edge when that would overflow the viewport. Steps with no targetSelector keep the current corner placement as a fallback. Add a scrim during an active tour — a dim overlay behind everything except the highlighted element, so the outline can stay subtle instead of fighting a fully-lit table. I'll gate this so it doesn't apply behind the card itself. Leave the mobile bottom-sheet untouched — the existing comments explain why it's a full-width sheet and it isn't part of this problem. Extend e2e/guidance-tour.spec.ts to assert the card lands within some reasonable distance of its target on a wide viewport, so this doesn't regress silently the way the corner-placement issue did. Does this plan sound right, or would you rather I try the simpler connector-line alternative you mentioned first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
