shivaansh0610-LUFFY commented on PR #621: URL: https://github.com/apache/fineract-backoffice-ui/pull/621#issuecomment-5848445562
@Aman-Mittal, Thanks for the review! Both comments came from the same root cause: savings-accounts-list.component.ts was still using ngx-translate’s native | translate pipe. I’ve migrated the component to the appTranslate adapter (TranslatePipe from core/adapters), matching the existing pattern in savings-account-view.component.ts. This removes the direct @ngx-translate/core import from the spec and eliminates the eslint-suppressions.json change. The test now uses provideFakeAdapters() plus the existing provideTranslateTesting() helper for the paginator used internally by app-data-table. Re-verified: npm run lint, npm run test:unit (1570/1570), npm run build, and npm run i18n:check all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
