somasorosdpc opened a new pull request, #6519:
URL: https://github.com/apache/fineract/pull/6519
## Description
Change
Registers both endpoints as batchable GET commands:
GetWorkingCapitalLoanBreachScheduleByLoanIdCommandStrategy and
GetWorkingCapitalLoanDelinquencyRangeScheduleByLoanIdCommandStrategy (new, in
fineract-working-capital-loan) — parse loanId from the batch sub-request's
relative URL, delegate to the existing
WorkingCapitalLoanBreachScheduleApiResource /
WorkingCapitalLoanDelinquencyRangeScheduleApiResource, and serialize the list
response.
CommandStrategyProvider.init() (fineract-core) — two new regex entries
mapping v1/working-capital-loans/{loanId}/breach-schedule and
v1/working-capital-loans/{loanId}/delinquency-range-schedule (GET) to the beans
above.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [ ] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
