shivaansh0610-LUFFY commented on PR #639: URL: https://github.com/apache/fineract-backoffice-ui/pull/639#issuecomment-5866573609
Thanks for taking a look, @Aman-Mittal. I want to make sure I get a chance to improve the right things. Here's what I was thinking for the Chargeback dialog: 1. Indicate which repayment is being charged back: the transaction date, the original amount and the maximum chargeable, so it's not just a generic confirmation. 2. Validate the amount inline: disallow amounts over the repayment amount and show an error, instead of letting it be rejected by the server. 3. Add transaction date and note fields, to match the other loan transaction dialogs. 4. Handle the payment type list better: a loading state, and a "None" option if the template fails to load, instead of a silently empty dropdown. 5. Use the src/app/ui/ primitives for the inputs and select, if you're happy with that over the raw elements. Is this the direction you had in mind, or were you referring to something else, such as the row action on the Transactions tab or the layout? I'm happy to tweak. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
