Samer-Melhem-FOO opened a new pull request, #6526: URL: https://github.com/apache/fineract/pull/6526
## Description [FINERACT-2863](https://issues.apache.org/jira/browse/FINERACT-2863) `GET /savingsaccounts/{accountId}?template=true` fills `productOptions` from `SavingsProductReadPlatformService.retrieveAllForLookup()`, which returns `SavingsProductData.lookup(id, name)` instances with a `null` `accountingRule`. `SavingsAccountsApiResource.retrieveOne` returns `SavingsAccountData` itself, so Jackson serializes it and calls the public `isCashBasedAccountingEnabled()` / `isAccrualBasedAccountingEnabled()` / `isUpfrontAccrualAccounting()` / `isPeriodicAccrualAccounting()` getters, which dereference the null rule. The request fails with `Cannot invoke "EnumOptionData.getValue()" because "this.accountingRule" is null`, so a pending savings application cannot be loaded for editing. The fix null-guards those getters, plus `hasAccountingEnabled()` and `accountingRuleTypeId()`, treating a missing accounting rule as "no accounting" (`false` / `AccountingRuleType.NONE`). Products that carry an accounting rule are evaluated as before. **Tests** - New `SavingsProductDataTest` (fineract-core): a lookup instance reports no accounting from every accessor and serializes with Jackson; an instance with a cash-based rule is still evaluated. Without the fix the two lookup cases fail with `NullPointerException`; with it all three pass. `spotlessJavaCheck`, `checkstyleMain` and `checkstyleTest` on fineract-core are clean. - Checked manually on a local `develop` build (PostgreSQL) with a savings product, a client and a pending savings application: `GET /savingsaccounts/{id}?template=true&associations=charges` and `GET /savingsaccounts/{id}?template=true` returned HTTP 400 with the NPE message before the change and HTTP 200 with `productOptions` after it. `GET /savingsaccounts/{id}` and `GET /savingsaccounts/template` are unchanged (200), and a `PUT /savingsaccounts/{id}` on the application is read back correctly with `template=true`. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
