Samer-Melhem-FOO opened a new pull request, #6530: URL: https://github.com/apache/fineract/pull/6530
## Description JIRA: https://issues.apache.org/jira/browse/FINERACT-2867 Submitting a new savings account application with a FLAT charge (`POST /savingsaccounts` with `charges`) fails with HTTP 500, a `NullPointerException` on `SavingsAccountCharge.savingsAccount().getCurrency()`. **Root cause:** `SavingsAccountChargeAssembler` builds the charges of a new application with `SavingsAccountCharge.createNewWithoutSavingsAccount(...)`, so `savingsAccount` is still null when the constructor calls `populateDerivedFields`. Since FINERACT-2284 the FLAT branch rounds the amount through `Money.of(savingsAccount().getCurrency(), ...)`, which dereferences the missing account. **Fix:** `populateDerivedFields` keeps the raw FLAT amount while the account is unknown, and `update(SavingsAccount)` applies the currency rounding to `amount` and `amountOutstanding` when the charge is first attached to its account. A FLAT charge submitted with a new application is therefore rounded the same way as one added to an existing account. **Tests:** new `SavingsAccountChargeWithoutSavingsAccountTest` (fineract-savings). It fails on `develop` with the NPE and passes with the fix. **Live check** (local bootRun on PostgreSQL): FLAT savings-activation charge of 10.126 USD submitted with a new application. On `develop`, HTTP 500 with the NPE. With the fix, HTTP 200, and the account's charge reads back with amount and outstanding 10.13. No API change. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
