mariowise commented on PR #6352: URL: https://github.com/apache/fineract/pull/6352#issuecomment-5897417802
Hi @adamsaghy, I've done the following to address your comments: 1. `principalPaymentGrace` is set only when the period is rewritten to interest-only inside the slice being recalculated, or when a period before that slice already has zero principal. 2. `shouldBeAdjusted()` now subtracts principal-grace periods only. Overpaid installments remain in `uncountablePeriods`, so they still stay out of the split, but they no longer lower the threshold or close the gate. Grace still lowers it. 3. Re-amortization and re-aging now record `PRINCIPAL_GRACE_LIFTED` on the schedule model, and that bit is copied with the model. The next recalculation does not rebuild grace from `graceOnPrincipalPayment`. Also rebased onto current `develop`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
