Samer-Melhem-FOO commented on PR #6196: URL: https://github.com/apache/fineract/pull/6196#issuecomment-5890343313
@adamsaghy Rebased onto the latest develop and fixed the failing collateral test. The test was failing because modifying a loan's collateral still didn't persist: the modify path replaced the loan's collateral rows with detached copies, so a changed quantity was saved as a second row next to the old one. The loan now updates the matching row in place. Resubmitting an unchanged quantity also no longer changes the client's remaining collateral. The three collateral tests are ported to the Feign client, and they now check both the loan's collateral and the client's remaining quantity. For that, the loan collateral swagger DTOs declare the `id` field the API already returns and accepts. All of `ClientLoanIntegrationTest` passes locally against PostgreSQL. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
