SamaSVM opened a new pull request, #6549:
URL: https://github.com/apache/fineract/pull/6549
## Description
Loan products/loan templates return the selected `loanScheduleType` and the
`loanScheduleTypeOptions` list in the same payload, but the same enum constant
is represented by different `id` values:
```json
{
"loanScheduleType": { "id": 0, "code": "CUMULATIVE" },
"loanScheduleTypeOptions": [
{ "id": 1, "code": "CUMULATIVE" },
{ "id": 2, "code": "PROGRESSIVE" }
]
}
```
As a result, a client that matches the selected option by `id` cannot find
the correct option or may select the wrong one. For example, `PROGRESSIVE` may
be returned with `id: 1`, while `id: 1` represents `CUMULATIVE` in the
`loanScheduleTypeOptions` list.
The selected `loanScheduleType` should use the same `id` as the
corresponding entry in `loanScheduleTypeOptions`.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [ ] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
