vianmangal opened a new pull request, #649: URL: https://github.com/apache/fineract-backoffice-ui/pull/649
# PR title fix: make label-backed UI text localizable # PR body ## What and why Three screens stored English display text in plain `label` fields and rendered it without translation, leaving those labels outside the i18n system. This replaces the literals with translation keys and resolves them through the application translation adapter. Dashboard chart-label translation is opt-in so labels derived from report data remain literal. Closes #627 ## Validation - `npm run test:unit` — 264 files, 1,702 tests passed - `npm run lint` - `npm run lint:prune` - `npm run i18n:check` - `npm run check:a11y-names` - `npm run check:icons` - `npm run format:check` - `npm run build` - `npm run ga:check` — 10/11 pass, with the repository's existing adapter-migration backlog reported as advisory and zero blocking failures The production build completed successfully with the existing `header.component.ts` style-budget warning. The UI was verified with unit-test fakes; no real Fineract backend was required because this change only affects label rendering. ## Screenshots Not applicable — this changes translated text resolution, not layout or styling. ## AI assistance (optional) - Tool / model: OpenAI Codex / GPT-5 - Harness / workflow: Codex desktop coding agent; the contributor reviewed the patch and remains responsible for the contribution. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. No workflow or backend behavior changed, so focused unit coverage is sufficient here. - [x] Commits are signed with a GitHub-verifiable GPG key. - [x] I followed the AI-assisted contributions guidance and disclosed the assistance above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
