DeathGun44 commented on PR #6516: URL: https://github.com/apache/fineract/pull/6516#issuecomment-5932860858
25,086 come from one line in ChargeData. feeOnMonthDay is a java.time.MonthDay, which the server never sends as an object. Jackson endpoints like GET /v1/charges send the ISO-8601 string --03-04, and Gson endpoints send [3, 4]. The schema generator introspected the type as a bean and published an object with dayOfMonth/month/monthValue. The total is that high because ChargeData is nested inside recursive savings and client schemas, so swagger-brake counts the field once per path across 44 endpoints. The 30 request-side hits on /v1/provisioningcriteria can't affect anyone either: the server only accepts id, name and includeInBorrowerCycle in each loanProducts entry. The other 25 come from four fixes, each covered by a migrated test: - Obligee details: the response is a bare array, not an object. - Internal client audit: the operation had no response schema, so its untyped default response is replaced by a typed 200. - Client identifier update: changes no longer advertises locale/dateFormat, which the server never returns. - Financial activity update: the response key is changes, not comments. In every case the old schema described a shape the server has never sent, so no client could have been relying on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
