opensource-joe opened a new pull request, #674:
URL: https://github.com/apache/fineract-backoffice-ui/pull/674
## What and why
Two i18n fixes from #388, one commit each.
Closes #388
**1. Five list headings were literal English.** Rechecked against current
`main` first: 9 of the 14 in the issue were fixed along the way, so this covers
the 5 left. Each now uses the key its route already uses for the browser tab
title, so the heading and the tab agree:
| Screen | Was | Now |
|---|---|---|
| Fixed deposit accounts | `Fixed Deposit Accounts` | `nav.fixedDeposits` |
| Recurring deposit accounts | `Recurring Deposit Accounts` |
`nav.recurringDeposits` |
| Share accounts | `Share Accounts` | `nav.shares` |
| Clients list, edit button tooltip | `Edit Client Details` |
`CLIENTS.EDIT_CLIENT` |
| Loan reschedule requests | `Loan Reschedule Requests` | new
`LOANS.RESCHEDULE_REQUESTS` |
The reschedule route has no title key to reuse, so that one gets a new key
in `en.json`. The two deposit headings get shorter as a result ("Fixed
Deposits" rather than "Fixed Deposit Accounts"). I went with matching the tab
title rather than adding three new `*_ACCOUNTS` keys, but happy to switch if
you'd rather keep the longer wording.
**2. Two product lists showed the account label.** `products/recurring` and
`products/share` rendered `nav.recurringDeposits` and `nav.shares`, so the tab
said "Recurring Deposit Products" while the heading said "Recurring Deposits".
Now `nav.recurringDepositProducts` and `nav.shareProducts`, the keys the routes
already use. No new translation entries.
Nothing in #251's claimed slices is touched.
## Verification
Mocked, on a dev server, Chromium. No real backend; these are template
strings and none of it touches a request.
- Loaded all seven screens and read the rendered heading and the tab title
on each. All seven show translated text, no raw keys, and heading and tab match
on the five list screens that have a route title.
- `npm run i18n:check` clean; hi and ko catalogues stay consistent with
`en.json`.
- Unit tests: 280 files, **1843 passed**.
- `npm run lint` and `prettier --check src e2e` clean.
- No e2e spec asserts any of the old heading text.
## Screenshots
Not added. Each change swaps one heading string for a key that renders the
text shown in the table. Happy to add captures if useful.
## AI assistance (optional)
- Tool / model: Claude Code
- Harness / workflow: Claude Code session driving my devbox. It rechecked
the issue against current `main`, made the edits, and ran the checks and the
browser pass listed above. I reviewed the diff, the commit messages and this
description before submitting.
## Checklist
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs. No new component or service code.
- [x] User-facing strings use translation keys. This is the change.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed. String-to-key swaps in templates; verified in the
browser and by `i18n:check`, which already guards that keys resolve.
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant. No workflow change.
- [x] Commits are signed.
- [x] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
