rk-roshan-kr opened a new pull request, #688: URL: https://github.com/apache/fineract-backoffice-ui/pull/688
## What and why Resolves all 14 violations of the `unicorn/no-array-sort` ESLint rule across 5 files: - Replaces in-place array mutation (`.sort()`) with pure `.toSorted()` in `DataTableComponent.sortRows`, `BusinessStepsComponent.loadSteps`, and unit test assertions. - Renames `DataTableComponent`'s internal `sort` `linkedSignal` to `currentSort` to eliminate AST selector false positives on signal reads (`this.sort()` / `component.sort()`). - Adds `"lib": ["ES2023", "DOM", "DOM.Iterable"]` to `tsconfig.json` to provide standard ES2023 typings for `Array.prototype.toSorted()`. - Prunes all 14 baseline suppressions from `eslint-suppressions.json`. Closes #679 ## Verification - `npm run lint:prune` (all 14 suppressions pruned from `eslint-suppressions.json`) - `npm run lint` (0 errors across entire repository) - `npm run test:unit` (285 test files passed, 1922 tests passed) - `npm run build` (production build succeeded) - `npm run check:icons` (all 117 icons verified) - `npm run i18n:check` (translations verified) ## Screenshots Not applicable. ## AI assistance (optional) - Tool / model: Google Antigravity / Gemini 2.5 - Harness / workflow: Pair programming for baseline lint violation resolution, typing validation, and regression test execution ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. - [x] I followed the [AI-assisted contributions guidance](CONTRIBUTING.md#ai-assisted-contributions). - [x] If this adds a feature or changes a workflow, I raised it on [email protected] first — or it is a bug fix, refactor or test change, where that does not apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
