msranjana opened a new pull request, #690:
URL: https://github.com/apache/fineract-backoffice-ui/pull/690
## What and why
Closes #678 . Specs were still reading and writing Web Storage directly, so
they could pass while bypassing the STORAGE adapter and leak keys between
tests. They now use `provideFakeAdapters()` and assert on the fake adapter,
which clears the `no-restricted-globals` lint baseline.
## Verification
- `npm run lint:prune` — removed all `no-restricted-globals` entries from
`eslint-suppressions.json`
- `npm run lint` — passed
- `npm run test:unit --
--include=src/app/core/services/auth.service.test.ts`
- `npm run test:unit --
--include=src/app/core/services/institution-config.service.test.ts
--include=src/app/core/services/navigation-config.service.test.ts
--include=src/app/shared/directives/has-institution-feature.directive.test.ts`
## Screenshots
Not applicable
## Checklist
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party
APIs.
- [x] User-facing strings use translation keys. *(no new strings)*
- [x] I added or updated tests appropriate to this change, or explained
why tests were
not needed.
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing
where relevant. *(not a UI workflow change)*
- [X] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in
CONTRIBUTING.md.
- [x] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [x] If this adds a feature or changes a workflow, I raised it on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
