rymghosn commented on PR #6226:
URL: https://github.com/apache/fineract/pull/6226#issuecomment-5989289677
@adamsaghy Thanks for the review. I've rebased onto the latest `develop` and
pushed the changes:
- `LoanCollateralManagementData` uses `@AllArgsConstructor` again. The
manual constructor is gone, and the three new fields (`name`, `unitPrice`,
`pctToBase`) are plain fields picked up by Lombok.
- Added `name`, `unitPrice` and `pctToBase` to
`GetLoansLoanIdCollateralData` in the Swagger model, so the generated client
exposes them.
- New integration test
`ClientLoanIntegrationTest.testLoanCollateralIncludesNameUnitPriceAndPercentageToBase`:
it creates a collateral product, attaches it to a loan, then checks that `GET
/loans/{id}?associations=collateral` returns the product's name, base price and
percentage-to-base. It passes against PostgreSQL, alongside the existing
collateral tests in that class.
Could you please re-review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
