rymghosn commented on PR #6292: URL: https://github.com/apache/fineract/pull/6292#issuecomment-5992454121
@adamsaghy Thanks, I've added `TaxGroupComponentEndDateChangeTest` and rebased on the latest `develop`. The test sets an end date on an existing tax group component and then changes it to another valid date. Writing it turned up a second gap: `TaxGroupMappings.update()` only applied an end date when none was set yet. With only the validator change, the second update returned 200 but kept the old date. The mapping now applies any changed end date, and the test checks the stored value after each update. To reach this path over REST, the PR also carries the `id`/`endDate` fields on `TaxGroupComponent` from #6291. Without them `develop` drops both from the request and the update fails with `dates.are.overlapping`. The hunk is identical to #6291, so the two merge cleanly in either order. Like #6291, the swagger now declares the `modifiedComponents` dates of the update response as dates, which is what the endpoint returns. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
