rymghosn commented on PR #6128: URL: https://github.com/apache/fineract/pull/6128#issuecomment-5993159693
@adamsaghy @Aman-Mittal Rebased on latest `develop`. Changes in this push: - **Fix:** the pending-submission lookup also matched on `loanId`/`savingsId` and fell back to client/group id. With maker-checker enabled for repayments, that meant a maker queuing a second repayment on the same loan got a 403 "duplicate pending submission". The lookup now matches only the command's own resource id (`entityId`), so transaction commands (repayments etc., which have no entity id) are never blocked. - Simplified `logCommandSource` as requested (see the inline reply). The custom `@Query` is replaced by a derived repository method. - Rewrote `LoanDisbursementMakerCheckerIntegrationTest` on the Feign client (develop now rejects new REST Assured tests). It also no longer leaves `enable-same-maker-checker` switched **on** after it finishes: the old `finally` block set it to `true`, though its default is `false`, which leaked into later tests in the same shard. - Added `PortfolioCommandSourceWritePlatformServiceImplTest`, covering duplicate disbursement, first disbursement, several pending repayments on one loan, and checker-only without a pending entry. The Shard 2 failure (`SavingsAccountsExternalIdTest` assuming savings product id 1) has been fixed on `develop` since, so the rebase should clear it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
