rymghosn commented on PR #6197: URL: https://github.com/apache/fineract/pull/6197#issuecomment-5993073640
@adamsaghy Rebased on latest `develop` and addressed your review: - Replaced the native query and recursive CTE with a JPQL repository query on `m_office.hierarchy` (`OfficeRepository.findIdsByHierarchyLike`). The relation type is read through `FineractEntityRelationRepository`. The existing mapping read is reused and filtered to the caller's office hierarchy, so the duplicated SELECT is gone. - Scoping now also applies when a specific office outside the caller's hierarchy is requested, not only for `fromId = 0`. - `EntityToEntityMappingIntegrationTest` is rewritten on the Feign client (develop now rejects new REST Assured tests) and checks the explicit-office case too. Added a unit test, `FineractEntityAccessReadServiceImplTest`. The earlier Shard 2 failure (`SavingsAccountsExternalIdTest` assuming savings product id 1) has been fixed on `develop` in the meantime, so the rebase should clear it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
