pwargulak opened a new pull request, #6575: URL: https://github.com/apache/fineract/pull/6575
## Description [FINERACT-2895](https://issues.apache.org/jira/browse/FINERACT-2895) On a progressive loan, reverse-replay can replace a `WAIVE_CHARGES` transaction even though waivers are not reprocessed. `useOldTransactionIfApplicable` kept the original waiver only when no other transaction on the same date had been replaced. Otherwise the caller registered a copy, and `copyTransactionProperties` does not carry the charge paid-by mappings for a waiver. Undo-waive then fails on both the copy and the reversed original. This change always keeps the original `WAIVE_CHARGES` transaction, which matches the existing comment ("WAIVE_CHARGES is not reprocessed"). `useOldTransactionIfApplicable` becomes package-private so it can be unit tested. Two tests are added: a waiver is kept when a same-day transaction was replaced, and a repayment in the same situation is still replaced as before. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API changes) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
