rymghosn opened a new pull request, #6576: URL: https://github.com/apache/fineract/pull/6576
## Description JIRA: [FINERACT-2894](https://issues.apache.org/jira/browse/FINERACT-2894) (the "Active status not persisted" part; the title/breadcrumb part of that ticket is in the web app and is not touched here). **Root cause:** the ad-hoc query API field is `isActive` (`AdHocRequest`, `AdHocJsonInputParams.ACTIVE`, `AdHocDataValidator`), but - `AdHoc.fromJson` read `isActive` and then discarded it with `.setActive(false)`, so every new query was created inactive; - `AdHoc.update` looked for a parameter named `active`, which never reaches the command (the body is bound to `AdHocRequest`), so `isActive` was never read on update. No request could change the flag, so the ad-hoc query job (`retrieveAllActiveAdHocQuery`) never picked a query up. **Fix:** use `isActive` in both places, and treat an explicit `null` on update as `false` instead of unboxing it. **Tests:** new `AdHocTest` (create with and without the flag, activate, deactivate, update without the flag leaves it unchanged). 3 of the 5 fail on current `develop`, all pass with the fix. **Manual verification** on a local build against PostgreSQL: - before: `POST /adhocquery` with `"isActive": true` → `GET` returns `"isActive": false`; `PUT {"isActive": true}` → 200 with no `changes`, still `false`. - after: create stores `true`; `PUT {"isActive": false}` / `{"isActive": true}` toggle the flag and return it in `changes`; a `PUT` that only renames leaves the flag unchanged. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change: the existing documented `isActive` field now takes effect) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. (this PR covers only the backend half of FINERACT-2894) - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
