pwargulak opened a new pull request, #6581: URL: https://github.com/apache/fineract/pull/6581
## Description [FINERACT-2898](https://issues.apache.org/jira/browse/FINERACT-2898) On progressive loans, `ChangeOperation#compareTo` orders charges by effective date, then by submitted date, then by creation time. Specified-due-date charges added on the same day therefore replay in creation order, whatever their due dates. When a payment made before that day is reprocessed, it is applied to those charges in that order, so a charge due later can be paid ahead of one due earlier. The creation order of charges added in one go carries no meaning, so otherwise identical loans can end up with different charges paid. This change compares the due dates (nulls last) when both operations are charges with equal effective and submitted dates, before falling back to creation time. Every other ordering is unchanged. `ChangeOperationTest` gains a test with two charges submitted on the same day and created out of due-date order, plus a payment dated before both; every permutation sorts to payment, earlier-due charge, later-due charge. It fails without the change. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
