rymghosn commented on PR #6291:
URL: https://github.com/apache/fineract/pull/6291#issuecomment-5992453490
@adamsaghy Thanks, I've added `TaxGroupComponentEndDateTest` and rebased on
the latest `develop`.
The test creates a tax group and then sets an end date on its existing
component through `PUT /taxes/group/{id}` (sending the mapping `id` plus
`endDate`). On `develop` the call fails with `400 dates.are.overlapping`. The
update request is bound to `TaxGroupRequest` and then re-serialized, and
`TaxGroupComponent` had no `id` or `endDate`, so both fields were dropped. The
server then treated the component as a new one that overlaps the existing
mapping. With this PR the test passes and the end date is stored on the
existing mapping.
While writing the test I also found that the swagger model declared the
`changes.modifiedComponents` dates of the update response as strings, but the
endpoint returns date arrays. The generated client couldn't read the response,
so the swagger now declares them as dates. I also documented `endDate` on the
association in the GET response. `checkBreakingChanges` reports no breaking API
changes.
Could you please re-review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
