rk-roshan-kr opened a new pull request, #713: URL: https://github.com/apache/fineract-backoffice-ui/pull/713
## Description This pull request addresses the client-side user experience defects reported in issue #671: 1. **Transaction Payment Type Validation**: Added the required attribute to the paymentTypeId select control across loan transaction forms (loan-transaction-form.component.ts), fixed deposit transaction forms (fixed-deposit-transaction-form.component.ts), and recurring deposit transaction forms (recurring-deposit-transaction-form.component.ts). This ensures payment type selection is validated on the client side before submission. 2. **Business Date Chip Display**: Initialized businessDate signal to null by default in header.component.ts and wrapped the template rendering in an @if (businessDate()) check so that unconfigured instances do not display an empty or hyphen chip. 3. **Login Error Message Specificity**: Refactored error handling in login.component.ts using status code inspection to distinguish 401 bad credentials, 404 endpoint not found, and network/CORS errors with appropriate user-facing messages in en.json. ## Validation - Added unit tests in header.component.test.ts verifying omission of the chip when null and proper display when populated. - Added unit tests in login.component.test.ts covering 401, 404, and status 0 errors. - Verified ESLint with npm run lint (0 errors). - Verified translation keys with npm run i18n:check. - Verified code formatting with prettier. Closes #671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
