adamsaghy commented on PR #6559:
URL: https://github.com/apache/fineract/pull/6559#issuecomment-6076737909
@DeathGun44 Please review the below concerns:
**Small test weakenings (low severity, each confirmed against old and new
code)**
- UserAdministrationTest.java:85: the duplicate-username create used to
require a 403 and now accepts any error. The sibling update test still checks
for 403. Add assertEquals(403, …getStatus()).
- DatatableAdvancedQueryTest.java:258: a missing or null boolean column now
passes. The old cast would have failed; asBoolean() treats null as false. Add a
check that the value is actually a boolean.
- Delete-datatable-entry checks: these now compare resourceId with the id
from the URL, so they can’t fail. The old tests checked
clientId/groupId/savingsId/loanId, which the server derives from the owning
entity. The new response model has no such fields, so restoring the check would
mean adding them to the Swagger class. Low value, since these are cleanup steps:
- EntityDatatableChecksIntegrationTest lines 156, 212, 275 and 346
- DatatableIntegrationTest lines 331, 431 and 881
- BusinessConfigurationApiTest: the step-order updates used to require
exactly 204 and now accept any 2xx. This is harmless, because the test reads
the configuration back after each update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
