rymghosn opened a new pull request, #6609: URL: https://github.com/apache/fineract/pull/6609
## Description JIRA: [FINERACT-2904](https://issues.apache.org/jira/browse/FINERACT-2904) Three small fixes to Entity Data Table Checks and datatable registration, one commit each. **1. Client checks are not enforced when the datatable subtype is not upper case** (`8f73602`) A client datatable registered with `entitySubType: "Person"` and covered by a check on `m_client` is never enforced: `POST /clients` without `datatables` succeeds, and so do activate and close. `EntityDatatableChecksWritePlatformServiceImpl.runTheCheck` upper-cases the subtype, but `EntityDatatableChecksRepository.findByEntityAndStatusAndSubtype` compares it with `rdt.subtype = :subtype`, and `x_registered_table.entity_subtype` keeps the case the caller sent. The query now compares `UPPER(rdt.subtype) = UPPER(:subtype)`, which covers every caller and every existing row without a data migration. **2. The checks template offers entities that cannot have a check** (`64ee865`) `GET /entityDatatableChecks/template` listed every `EntityTables` value, including entities with no check statuses (`m_center`, `m_office`, `m_product_loan`, `m_savings_product`, ...). Creating a check for one of them always failed with "status must be one of [ ]". The new `EntityTables.getCheckableEntityNames()` is now used for the template's `entities` and the validator's `entity` check, and the status check only runs for an entity that supports checks, so an unsupported entity gets a single `entity` error. Datatable registration still accepts every entity. **3. A String column without a length returns a raw message key** (`76a69fc`) `POST /datatables` with a `String` column and no `length` returned "Failed data validation due to: must.be.provided.when.type.is.String.". The new `DataValidatorBuilder.failWithCodeAndMessage` returns "Column length is required for String columns (<column>)." The error code is unchanged. **Tests** - `FeignClientEntityDatatableCheckSubtypeTest` (integration): client create and activate against a `"Person"` datatable with a check are rejected without the entry. - `EntityDatatableChecksDataValidatorTest`, `EntityDatatableChecksReadPlatformServiceImplTest`, `DatatableCommandFromApiJsonDeserializerTest` (unit): 14 tests. Against the unfixed `develop` code, 9 of them fail; the other 5 cover entities that are accepted either way. - The existing `EntityDatatableChecksIntegrationTest` (12 tests) still passes. - Fix 1 was also verified red/green against a local PostgreSQL instance: on `develop`, the client create returns 200; with the fix, it returns 403 `error.msg.entry.required.in.datatable.[<dt>]`. No API changes: no new endpoints or parameters, only corrected validation and template content. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
