[ 
https://issues.apache.org/jira/browse/FINERACT-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladyslav Samchenko resolved FINERACT-2841.
-------------------------------------------
    Resolution: Fixed

> Savings account charge update silently ignores/corrupts unsupported 
> ChargeCalculationType values and throws NPE for PERCENT_OF_AMOUNT
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-2841
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2841
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Vladyslav Samchenko
>            Assignee: Vladyslav Samchenko
>            Priority: Trivial
>             Fix For: 1.16.0
>
>
> {{SavingsAccountCharge#update(...)}} (both the {{JsonCommand}} overload and 
> the 4-argument overload) switches on {{ChargeCalculationType}} and includes a 
> case for every enum constant, even though savings charges only support 
> {{FLAT}} and {{{}PERCENT_OF_AMOUNT{}}}, as defined by 
> {{ChargeCalculationType#validValuesForSavings()}} and enforced on the charge 
> definition by {{Charge#validate()}} / {{{}update(){}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to