Aman-Mittal opened a new issue, #161:
URL: https://github.com/apache/fineract-consumer-facing/issues/161
## Problem
The BFF compiles its Fineract client against the vendored spec at
`consumer/src/main/java/org/apache/fineract/consumer/infrastructure/fineractclient/spec/fineract.json`.
That spec reports `info.version` `1.15.0-SNAPSHOT`. The compose stack and CI
run `apache/fineract:1.12.1`, so the client is tested against a different
Fineract than the one it is built from. Nothing checks that the two agree.
Fineract `develop` has also moved on (`1.16.0-SNAPSHOT`):
- several operationIds were renamed, so the generated method names changed;
- `GET /savingsaccounts/{id}/transactions/{txnId}` now declares a typed
response, which removes the need for the String + `ObjectMapper` workaround in
`SavingsQueryServiceImpl`.
Docker Hub has no `apache/fineract` image for 1.13–1.15. The newest images
are `develop` and per-commit tags.
## Proposal
1. Re-vendor the spec from the published `develop` image. It ships at
`/app/resources/static/fineract.json`.
2. Pin `consumer/compose.yaml` to that same image tag, so the client and its
test runtime come from one build.
3. Allow the tag to be overridden (`FINERACT_IMAGE_TAG`), so CI can also run
against moving `develop`.
4. Adapt the BFF to the renamed operations.
## Acceptance criteria
- The vendored spec and the compose image come from the same
`apache/fineract` build.
- Unit tests and the full Cucumber suite pass against that image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
