Ashutosh-Panda2004 opened a new pull request, #6615:
URL: https://github.com/apache/fineract/pull/6615
## Description
Part of FINERACT-2827 (OpenAPI gaps: Admin Products). This covers two
sections of the ticket that are still open on develop:
* `GET /savingsproducts/{productId}` — `GetSavingsProductsProductIdResponse`
was missing most of the fields the API returns for a savings product. Added the
fields `SavingsProductData` carries for a single product:
minRequiredOpeningBalance, lockinPeriodFrequency, lockinPeriodFrequencyType,
allowOverdraft, overdraftLimit, minRequiredBalance, enforceMinRequiredBalance,
maxAllowedLienLimit, lienAllowed, minBalanceForInterestCalculation,
nominalAnnualInterestRateOverdraft, minOverdraftForInterestCalculation,
withHoldTax, taxGroup, isDormancyTrackingActive, daysToInactive, daysToDormancy
and daysToEscheat, with nested types for the lock-in period frequency type and
for the tax group (id and name).
* `GET /charges/template` — `GetChargesTemplateResponse` did not document
`taxGroupOptions`, although the API returns it. Added it, typed with the
existing `GetChargesTaxGroup`, which carries the id and name.
### Testing
I could not run the Gradle build locally (no network access to fetch the
dependencies in my environment), so the change was verified by static analysis
against the current develop sources: every added field was checked against
`SavingsProductData` (the payload built for a single product) and against
`ChargeReadPlatformServiceImpl`, which populates the charge template's tax
group options. CI will have to be the build check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
