Aman-Mittal opened a new issue, #187:
URL: https://github.com/apache/fineract-consumer-facing/issues/187
Part of #186.
`AGENTS.md` ("Naming") requires classes under a feature's `command/data/` to
end in `Command`, `CommandData`, `CommandRequest` or `CommandResponse`. The
rule `NamingArchitectureTest` (command `data/` suffix) is frozen with three
existing violations:
- `authentication.command.data.PrincipalUserAuthData`
- `authentication.command.data.PrincipalUserAuthCredentialsData`
- `beneficiaries.command.data.ResolvedBeneficiaryAccount`
Rename each to a name with a suffix that fits its role (for example
`...CommandData`) and update its references.
- The classes are internal to the BFF and not part of its HTTP contract.
Check that none is serialized under its class name before renaming.
- After the rename, run `./gradlew test --tests '*Architecture*'`. The
entries disappear from the store file under
`consumer/src/test/resources/archunit_store/`; commit the smaller file with the
change.
Done when that store file is empty or removed and `./gradlew test` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
