Aman-Mittal opened a new issue, #173:
URL: https://github.com/apache/fineract-consumer-facing/issues/173
Part of #172.
These are the two core files in the suppressions baseline. Both need more
care than the template-only components.
**`src/app/core/i18n/i18n.service.ts`** injects ngx-translate's
`TranslateService` and persists the chosen language with `localStorage`
(`app.lang`).
- Rebase it on `I18N` (`translate`, `use`) and `STORAGE`
(`read('language')`, `write('language', …)`).
- Alternatively, fold it into the adapter and update its callers: the error
interceptor, `NotificationService`, the language switcher, and three components
that show toasts.
- Keep the language restored at startup.
**`src/app/core/auth/device-fingerprint.ts`** reads and writes the
per-browser device id (`bff.device-id`) with `localStorage`.
- It is a plain function called from the auth interceptor and the BFF
adapters, outside any injection context. Moving it onto `STORAGE` therefore
means either an injectable `DeviceFingerprint` service, or passing the storage
in.
- The fingerprint is bound into the session token, so the stored value and
its key name must not change, or every signed-in user is logged out.
Done when both files' entries are gone from
`frontend/eslint-suppressions.json` (`npm run lint:prune`), and `npm run lint`
and `npm test` pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
