ayushcodes27 opened a new pull request, #195:
URL: https://github.com/apache/fineract-consumer-facing/pull/195
## What and why
Migrate `savings-detail.component.ts`, `savings-list.component.ts`, and
`savings-transaction.component.ts` to the application translation adapter:
- Swapped `import { TranslatePipe } from '@ngx-translate/core'` to `import {
TranslatePipe } from '../../core/adapters'`.
- Updated template pipe usages from `| translate` to `| appTranslate`.
- Pruned the three migrated entries from `eslint-suppressions.json`.
Part of #172. Fixes #178.
## Verification
- `npm run lint`: passed cleanly (0 errors).
- `npm run i18n:check`: passed cleanly.
- `npm test -- --watch=false`: 109 unit tests pass. 35 store/service tests
fail locally, most likely because of the stub;
`.github/workflows/build-tests-frontend.yml` generates the real client via `npm
run e2e:docker:up:backend && npm run generate:client` before running `npm test`.
- Verified none of the three migrated components have unit specs
(`Get-ChildItem src/app/features/savings -Recurse -Filter "*.spec.ts"` returns
only `savings.store.spec.ts`).
- Commits are cryptographically signed.
## Screenshots
Not applicable (pure template pipe refactoring with no UI or layout changes).
## AI assistance (optional)
- Tool / model: Gemini, Claude
- Harness / workflow: chat assistance for planning, refactoring, and
verification
## Checklist
- [x] I did not hand-edit generated files under
`frontend/src/openapi-client/` (the stub at `src/openapi-client/index.ts` is
local-only, gitignored, and not part of this PR).
- [x] Backend code follows the feature and CQRS layout in
[AGENTS.md](AGENTS.md#backend-conventions-consumer) (command and query sides,
module boundaries); frontend code goes through the adapters in
`frontend/src/app/core/adapters/`.
- [x] I did not add entries to a lint or architecture baseline
(suppressions, frozen violations) to get the build passing.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed (no new tests: mechanical template change, none of these
three components have unit specs, and lint plus i18n:check cover the migration).
- [ ] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant. *(N/A: mechanical template refactoring
without workflow changes)*
- [x] Commits are signed — see [Signing your
commits](CONTRIBUTING.md#signing-your-commits) in CONTRIBUTING.md.
- [x] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [x] If this adds a feature or changes what a consumer can see or do, I
raised it on
[[email protected]](https://lists.apache.org/[email protected])
first,
or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
