FenjuFu opened a new pull request, #198:
URL: https://github.com/apache/fineract-consumer-facing/pull/198
## What and why
Moves the profile and settings screens behind the I18N adapter, following
the steps in #172: the components import `TranslatePipe` from `core/adapters`,
templates use `| appTranslate`, and the change-password spec uses
`provideI18nTesting()`. The four files are pruned from
`frontend/eslint-suppressions.json`. No behaviour change; the pipe resolves the
same keys through the same catalogue.
Part of #172.
Closes #179
## Verification
- `npm run lint:prune`, then `npm run lint`: clean, and the four entries are
gone from the baseline.
- `npm run i18n:check`: passes.
- Prettier check on the changed files: clean.
- `npm test` needs the generated BFF client, which needs the backend Docker
stack; I don't have Docker on this machine, so the Vitest run is left to CI.
The spec change only swaps `provideTranslateService()` for
`...provideI18nTesting()`, which returns the same provider.
## Screenshots
Not applicable (no visual change).
## Checklist
- [x] I did not hand-edit generated files under
`frontend/src/openapi-client/`.
- [x] Backend code follows the feature and CQRS layout in
[AGENTS.md](AGENTS.md#backend-conventions-consumer) (command and query sides,
module boundaries); frontend code goes through the adapters in
`frontend/src/app/core/adapters/`.
- [x] I did not add entries to a lint or architecture baseline
(suppressions, frozen violations) to get the build passing.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed. (Refactor only; the existing spec was updated to the
testing helper.)
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant. (No workflow change.)
- [x] Commits are signed — see [Signing your
commits](CONTRIBUTING.md#signing-your-commits) in CONTRIBUTING.md.
- [x] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [x] If this adds a feature or changes what a consumer can see or do, I
raised it on
[[email protected]](https://lists.apache.org/[email protected])
first,
or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
