ayushcodes27 opened a new pull request, #200:
URL: https://github.com/apache/fineract-consumer-facing/pull/200

   ## What and why
   
   Migrates the beneficiaries feature screen behind the I18N adapter boundary 
by swapping the `@ngx-translate/core` import for `core/adapters`, renaming 
template pipes to `appTranslate`, and pruning ESLint suppression entries.
   
   Closes #175
   Part of #172
   
   ## Verification
   
   - `npm test -- --include 
src/app/features/beneficiaries/beneficiaries.component.spec.ts` (3 tests passed)
   - `npm run lint` (passed, 0 errors)
   - `npm run i18n:check` (passed)
   - `npx prettier --check "src/app/features/beneficiaries/**" 
eslint-suppressions.json` (passed)
   
   ## Screenshots
   
   Not applicable (pure refactoring to adapter pipe; UI display and strings 
remain unchanged).
   
   ## AI assistance (optional)
   
   - Tool / model: Gemini, Claude
   - Harness / workflow: reviews and verification
   
   ## Checklist
   
   - [x] I did not hand-edit generated files under 
`frontend/src/openapi-client/`.
   - [x] Backend code follows the feature and CQRS layout in 
[AGENTS.md](AGENTS.md#backend-conventions-consumer) (command and query sides, 
module boundaries); frontend code goes through the adapters in 
`frontend/src/app/core/adapters/`.
   - [x] I did not add entries to a lint or architecture baseline 
(suppressions, frozen violations) to get the build passing.
   - [x] User-facing strings use translation keys.
   - [x] I added or updated tests appropriate to this change, or explained why 
tests were not needed.
   - [x] UI workflow changes include suitable e2e coverage, including 
real-backend testing where relevant.
   - [x] Commits are signed — see [Signing your 
commits](CONTRIBUTING.md#signing-your-commits) in CONTRIBUTING.md.
   - [x] I followed the [AI-assisted contributions 
guidance](CONTRIBUTING.md#ai-assisted-contributions).
   - [x] If this adds a feature or changes what a consumer can see or do, I 
raised it on
         
[[email protected]](https://lists.apache.org/[email protected])
 first,
         or it is a bug fix, refactor or test change, where that does not apply.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to