1cbyc opened a new pull request, #201:
URL: https://github.com/apache/fineract-consumer-facing/pull/201

   ## What and why
   
   Migrate the consent and demo components from direct ngx-translate usage to 
the application i18n adapter. The consent test now uses the shared i18n test 
provider, and the three obsolete lint suppressions are removed.
   
   Closes #176
   
   ## Verification
   
   - `npm run lint:prune`
   - `npm run lint`
   - `npm test -- --watch=false` (24 files, 144 tests)
   - `npm run i18n:check`
   - `git diff --check`
   
   ## Screenshots
   
   Not applicable; this is an adapter migration with no UI behavior change.
   
   ## Checklist
   
   - [x] I did not hand-edit generated files under 
`frontend/src/openapi-client/`.
   - [x] Backend code follows the feature and CQRS layout in 
[AGENTS.md](AGENTS.md#backend-conventions-consumer) (command and query sides, 
module boundaries); frontend code goes through the adapters in 
`frontend/src/app/core/adapters/`.
   - [x] I did not add entries to a lint or architecture baseline 
(suppressions, frozen violations) to get the build passing.
   - [x] User-facing strings use translation keys.
   - [x] Existing focused component tests cover the unchanged behavior; the 
full frontend unit suite passes.
   - [x] No UI workflow changed, so new e2e coverage is not applicable.
   - [x] Commits are signed — see [Signing your 
commits](CONTRIBUTING.md#signing-your-commits) in CONTRIBUTING.md.
   - [x] I followed the [AI-assisted contributions 
guidance](CONTRIBUTING.md#ai-assisted-contributions).
   - [x] This is a requested refactor and does not add or change consumer 
behavior, so a mailing-list proposal is not applicable.
   
   Co-authored-by: insisong <[email protected]>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to