adamsaghy commented on PR #6237: URL: https://github.com/apache/fineract/pull/6237#issuecomment-6125191636
@rymghosn Please review below concerns: - payCharge now pays the gross (tax-inclusive) amount, but callers pass amountPaid = amountOutstanding, which is the base. So SavingsAccountCharge.pay() (:374-387) drives the outstanding negative and the charge is never marked paid. Recurring fees also never move to their next due date. Later manual payments will then fail the “paid in excess” check. -in the overdraft-split branch, both legs receive the full taxPayments list. Tax is posted twice and income is understated. - at the journal-entry level: a tax component’s credit account is optional. When it’s missing, the tax is still subtracted from income but no VAT leg is posted. That gives a gross debit against only a net credit. I didn’t check whether a later step rejects the unbalanced set. - No tests. The description claims two fixes, the TaxComponent↔History mapping and the empty-components validation, that are already on develop through FINERACT-2766 and FINERACT-2748. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
