nemux opened a new pull request, #6626:
URL: https://github.com/apache/fineract/pull/6626
## Description
## Problem
When "Force Withdrawal" (FINERACT-2471) pushes a savings account balance
below its minimum/zero threshold, any subsequent REGULAR (non-forced)
withdrawal on that same account throws InsufficientAccountBalanceException,
even when the account's current balance is fully sufficient.
Root cause: validateAccountBalanceConstraints(BigDecimal, ...) replays the
entire transaction history on every balance-affecting operation. The
isForceWithdrawal authorization was only a call-scoped boolean, never
persisted on the transaction itself, so a later regular withdrawal
(isForceWithdrawal=false for that call) re-fails when the loop re-encounters
the earlier, legitimately-authorized forced dip.
## Fix
- Persist a new is_force_transaction flag on m_savings_account_transaction,
set at creation time when the transaction originates from the Force
Withdrawal command.
- isForceWithdrawalAllowed(...) now checks this per-transaction flag (in
addition to the current call's flag), so historical authorized dips remain
recognized regardless of what later operation triggers a re-validation.
- Backfill migration for accounts that already have force-withdrawal
transactions predating this flag, using the m_portfolio_command_source
audit trail (action_name=FORCE_WITHDRAWAL) to identify them.
## Scope note
A related but distinct bug affects undo/adjust/waiveCharge/payCharge (which
use a different validateAccountBalanceConstraints(String, ...) overload with
no force-withdrawal awareness at all). That is tracked and fixed separately
in FINERACT-2929, built on top of this branch.
## Testing
Added testRegularWithdrawalSucceedsAfterEarlierForceWithdrawalRecoversBalance
to SavingsAccountForceWithdrawalTest, reproducing the exact reported
scenario.
Fixes FINERACT-2471.
```
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [X] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [X] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [X] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [X] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [X] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [X] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [X] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [X] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
