KRYSTALM7 commented on code in PR #170:
URL:
https://github.com/apache/fineract-loan-origination/pull/170#discussion_r4255578368
##########
src/main/java/org/apache/fineract/los/api/CustomerLoanApplicationController.java:
##########
@@ -157,7 +157,10 @@ private void assertOwnedByCaller(
final Long ownerClientId =
loanApplicationService.getFineractClientIdOrThrow(application);
if (!ownerClientId.equals(principal.getClientId())) {
- throw new AccessDeniedException("Application does not belong to this
customer");
Review Comment:
Good choice to use "ApplicationNotFoundException" specifically for this
ownership check rather than changing global "AccessDeniedException" handling.
This keeps the anti-enumeration behavior scoped to customer-owned applications
and avoids conflicting with the separate 403 fix in #159.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
