samchinmaya opened a new pull request, #6632: URL: https://github.com/apache/fineract/pull/6632
## Description JIRA: [FINERACT-2933](https://issues.apache.org/jira/browse/FINERACT-2933) `GET /clients/{clientId}/collaterals` always returns an empty list when the optional `prodId` query parameter is not given, even though the client has collaterals (`GET /clients/{clientId}/collaterals/{id}` returns them, and `?prodId=<loan product>` lists them). Cause: `ClientCollateralManagementRepositoryWrapper.getClientCollateralData()` only adds a collateral when `prodId != null && <collateral currency equals the loan product currency>`, so without `prodId` nothing is ever added. The code has been like this since the collateral module was added (#1770). Change: - `getClientCollateralData()`: the currency filter only applies when a loan product is given (`prodId == null || <currency matches>`). With `prodId` the result is unchanged. - New `ClientCollateralManagementRepositoryWrapperTest`: without a loan product every collateral is listed; with one, only the collaterals in its currency. Verification: - `ClientCollateralManagementRepositoryWrapperTest` passes (2/2); `spotlessJavaApply`, `checkstyleMain` and `checkstyleTest` pass. - Real API, on a Fineract image built from this branch, for a client with one collateral (USD) and a USD loan product: - `GET /clients/2/collaterals` returns the collateral (on develop: `[]`). - `GET /clients/2/collaterals?prodId=1` returns the same collateral as before. - A client without collaterals still returns `[]`. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
