rymghosn commented on PR #6290: URL: https://github.com/apache/fineract/pull/6290#issuecomment-6143071876
@adamsaghy Thanks for the review. Rebased on the latest `develop` and addressed each point: - **Start date after end date.** When a start date changes, it is now checked against the mapping's existing end date and rejected with `must.be.before.end.date` if it is not earlier. - **groupEditable vs the JIRA.** `groupEditable` is now simply `false` whenever the group is linked to a charge, savings product or savings account, and `componentEditable` is `false` on a linked group. The write path enforces it too: a start-date change on a linked group is rejected with `cannot.be.modified.for.linked.tax.group`. End dates stay editable, and components can still be added, as on `develop`. - **New component with a past start date.** I removed the JSON-level start-date check, so a new component behaves as it does on `develop`. Only start-date changes to existing mappings are restricted, and the template flags reflect that. - **Tests.** `TaxGroupComponentStartDateTest` now has 7 cases: both template flags (linked and unlinked), the linked-group rejection, the end-date bound, and adding a backdated new component. The FK fix this PR carried is now already on `develop` (`TaxGroup.update` sets the group on new mappings), so it has dropped out of this diff. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
