rymghosn commented on PR #6286: URL: https://github.com/apache/fineract/pull/6286#issuecomment-6144083666
@adamsaghy Thanks for the review. Rebased on the latest `develop` and addressed the points: - **Description:** rewritten to match the code. It no longer mentions `findByName` / `existsByNameIgnoreCase`, the `tax.*.name.must.be.unique` codes or the duplicate-component check. It describes the constraints, the 403 `error.msg.tax.*.duplicate.name` mapping and the collation-dependent case sensitivity. - **Generated name already taken:** the changeset now runs the rename twice per table. A clash left after the first pass can only be between a renamed row and a row that already had that exact `<name> (<id>)`, and the second pass gives the newer of the two its own id. I ran it on PostgreSQL with that case seeded, in both orders (the pre-existing row older and newer than the renamed one), plus plain duplicates and a name longer than 30 characters. All changesets applied, and both constraints were created. - **Numbering:** `develop` has since gained `0257`, so `0258` now follows it directly with no gap. `TaxNameUniquenessTest` and the existing tax integration tests pass. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
