budaidev commented on PR #6601: URL: https://github.com/apache/fineract/pull/6601#issuecomment-6144900879
@galovics a correction to my earlier reply. Repayment and undo still run one extra query, the RESCHEDULE action lookup, not zero. That lookup has to stay because a RESCHEDULE action can exist without a product-level near-breach config. Thanks @adamsaghy for catching it. @adamsaghy thanks, all six are fixed: 1 and 2. When a replay, reset, undo-reset or ENABLE moves a period's dates or minimum payment, the period now goes back to null and gets a value only once a checkpoint of the new bounds has elapsed. COB and repayments still keep the value. A new integration test covers the pause case. 2. Repayments, undos and rebuilds now use the loan's lastClosedBusinessDate, capped at business date - 1. 3. Split and restore go through the guarded reprocess again, and replayForBreachAction has the guard too. 4. rederiveSince no longer checks isBreachDisabled. There is one resolveParameters now, and COB does its own disabled check. 5. A plain reprocess builds the baseline from the schedule it already loaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
