adamsaghy commented on PR #6288: URL: https://github.com/apache/fineract/pull/6288#issuecomment-6152708155
@rymghosn Please review below concerns: **Issues (all confirmed):** - “Strictly after today” isn’t enforced. validateDateAfter(today) accepts today (TaxValidator.java:349). - Renaming fails if the client sends the whole form. parameterExists rejects unchanged percentage and account fields, so a full-form rename on an in-use component is refused (TaxWritePlatformServiceImpl.java:141-175). - GL account updates aren’t validated. debitAccountType: 9 silently stores null. - “In use” only checks charges. A component used only for savings withholding tax stays fully editable, which goes against the JIRA. - Moving a future start date with no percentage change writes no history row. This leaves a gap where no rate applies, so no tax is calculated for that period. - Spotless will fail. The merge commit put the imports out of order (TaxReadPlatformServiceImpl.java:28-29). - Tests: None. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
